Re: QUERY: Inclusion of header files in kernel header files

From: Borislav Petkov
Date: Tue Feb 23 2010 - 08:01:23 EST


From: viresh kumar <viresh.linux@xxxxxxxxx>
Date: Tue, Feb 23, 2010 at 05:07:47PM +0530

> >> I think, ideally including any header file shouldn't give compilation
> >> errors for types used in
> >> included header file.
> >
> > Agreed.
> >
> > I'd send a patch fixing the bus.h header, in case no one has a valid
> > technical reason against it.
> >
>
> That will be great!!!

Just to make sure: with "I'd" I meant "I would", i.e. actually _you_
could send a patch fixing that by explaining the problem in the commit
message :).

> Actually this issue is not present only in bus.h, but some other
> kernel header files.
> Like: arch/arm/include/asm/clkdev.h don't include list.h file but
> using struct list_head
>
> May be we need to check this in other header files also.

Well, you should talk to the arm maintainer about that task and whether
it is desirable.

--
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/