Re: [PATCH] m68k,m68knommu: missing asterisk?

From: Geert Uytterhoeven
Date: Tue Feb 23 2010 - 01:13:42 EST


On Sat, Feb 20, 2010 at 01:37, Roel Kluin <roel.kluin@xxxxxxxxx> wrote:
> An asterisk was missing.
>
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
> Correct?

No, see arch/m68k/apollo/config.c:dn_dummy_hwclk().
Andrew: please dequeue.

> Âarch/m68k/include/asm/apollohw.h | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/m68k/include/asm/apollohw.h b/arch/m68k/include/asm/apollohw.h
> index a1373b9..87e0cc4 100644
> --- a/arch/m68k/include/asm/apollohw.h
> +++ b/arch/m68k/include/asm/apollohw.h
> @@ -94,7 +94,7 @@ extern u_long timer_physaddr;
>
> Â#define sio01 ((*(volatile struct SCN2681 *)(IO_BASE + sio01_physaddr)))
> Â#define sio23 ((*(volatile struct SCN2681 *)(IO_BASE + sio23_physaddr)))
> -#define rtc (((volatile struct mc146818 *)(IO_BASE + rtc_physaddr)))
> +#define rtc ((*(volatile struct mc146818 *)(IO_BASE + rtc_physaddr)))
> Â#define cpuctrl (*(volatile unsigned int *)(IO_BASE + cpuctrl_physaddr))
> Â#define pica (IO_BASE + pica_physaddr)
> Â#define picb (IO_BASE + picb_physaddr)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/