Re: [PATCH] scripts: improve checkstack

From: Steven Rostedt
Date: Mon Feb 22 2010 - 12:59:12 EST


On Mon, 2010-02-22 at 08:58 -0800, Arjan van de Ven wrote:
> On 2/22/2010 8:43, Stephen Hemminger wrote:
>
>
> btw as a general comment on these guys
>
> "make it more perl-ish" is not a good feature for me.
>
> "make it more readable" would be.
>
> these guys are not performance sensitive, lets make them as readable as possible, and not line noise.
>

Acked-by: Steven Rostedt

That is, I've purposely did not do "perlish" code in the perl scripts
that I wrote, and have consistently NACKed changes to make it so.

The perl scripts in the kernel need to be "C-ish" not "perl-ish", that
way the other 70% of the kernel programmers that do not do perl can
still understand these scripts.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/