Re: [PATCH] [4/4] SLAB: Fix node add timer race in cache_reap

From: Pekka Enberg
Date: Mon Feb 22 2010 - 05:57:17 EST


Christoph Lameter kirjoitti:
On Mon, 15 Feb 2010, Andi Kleen wrote:

How, may I ask? cpuup_prepare in the hotplug notifier should always
run before start_cpu_timer.
I'm not fully sure, but I have the oops to prove it :)

I still suspect that this has something to do with Pekka's changing the
boot order for allocator bootstrap. Can we clarify why these problems
exist before we try band aid?

I don't see how my changes broke things but maybe I'm not looking hard enough. Cache reaping is still setup from cpucache_init() which is an initcall which is not affected by my changes AFAICT and from cpuup_callback() which shoulda also not be affected.

Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/