Re: tools/perf: libraries must come after objects

From: Ingo Molnar
Date: Mon Feb 22 2010 - 05:50:42 EST



* Jan Engelhardt <jengelh@xxxxxxxxxx> wrote:

> parent b4bdd73ce865213a5653dc424873e8da37e858cc (v2.6.32.7)
> commit 588424af1a51fa41ea4811200889d6a03219c6fd
> Author: Jan Engelhardt <jengelh@xxxxxxxxxx>
> Date: Thu Feb 11 01:20:54 2010 +0100
>
> tools/perf: libraries must come after objects
>
> Link order matters, especially now since distributions are
> using -Wl,--as-needed.
>
> Signed-off-by: Jan Engelhardt <jengelh@xxxxxxxxxx>
> ---
> tools/perf/Makefile | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)

FYI, this patch doesnt apply to the latest version of perf:

patching file tools/perf/Makefile
Hunk #1 FAILED at 201.
Hunk #2 FAILED at 421.
Hunk #3 FAILED at 432.
Hunk #4 succeeded at 770 (offset 93 lines).
3 out of 4 hunks FAILED -- rejects in file tools/perf/Makefile

you can find the devel tree at:

http://people.redhat.com/mingo/tip.git/README

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/