Re: [PATCH 2/3] tracing/kprobes: Make Kconfig dependencies generic

[Frederic Weisbecker]

On Thu, Feb 18, 2010 at 11:19:54AM -0500, Masami Hiramatsu wrote:
> > For now it is stored is asm/ptrace.h, but that might be split in
> > the future, especially as ptrace has initially nothing related to
> > that. A documentation that deals with filenames or API enumerations
> > tend to be incidentally async with API evolutions.
> 
> yeah, now those APIs depend on pt_regs, so I put it in ptrace.h.
> 
> Thank you,


Are you guys fine with the following patch or should I bring
more details somewhere?

Thanks.

---
commit d3643132cfeac24ee20d2b6cd8cb06d73e6a6da9
Author: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
Date:   Thu Feb 18 14:25:21 2010 +0100

    tracing/kprobes: Add short documentation for HAVE_REGS_AND_STACK_ACCESS_API
    
    So that arch developers know how to implement it without the
    need to dig into changelogs.
    
    Reported-by: Mike Frysinger <vapier.adi@xxxxxxxxx>
    Signed-off-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
    Cc: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
    Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
    Cc: "David S . Miller" <davem@xxxxxxxxxxxxx>
    Cc: Paul Mundt <lethal@xxxxxxxxxxxx>
    Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
    LKML-Reference: <20100218132521.GB2406@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
    [added reference to ptrace.h in the config help]
    Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>

diff --git a/arch/Kconfig b/arch/Kconfig
index 04e3aa7..50877ef 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -123,6 +123,11 @@ config USE_GENERIC_SMP_HELPERS
 
 config HAVE_REGS_AND_STACK_ACCESS_API
 	bool
+	help
+	  This symbol should be selected by an architecure if it supports
+	  the API needed to access registers and stack entries from pt_regs,
+	  declared in asm/ptrace.h
+	  For example the kprobes-based event tracer needs this API.
 
 config HAVE_CLK
 	bool


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/