Re: [PATCH] LSM: add static to security_ops variable

From: Alexey Dobriyan
Date: Fri Feb 19 2010 - 06:44:52 EST


On Sun, Feb 7, 2010 at 1:24 PM, wzt wzt <wzt.wzt@xxxxxxxxx> wrote:
> security_ops was declared as a global variable, so other drivers or
> kernel code can easily change its value, like:

With your patch they still can.

> extern struct security_operations *security_ops;
> security_ops = NULL;
>
> then insmod this driver immediately, it will get an oops.  Other evil
> drivers can aslo fake this variable as extern.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/