Re: [PATCH 3/3] vt: Fix refcounting use

From: Alan Cox
Date: Wed Feb 17 2010 - 11:32:45 EST


> This is the only bit that immediately stands out..
> maybe?
> if (rep || !tty) {
> if (tty)
> tty_kref_put(tty);
> return;
> }

tty_kref_put(NULL) is valid - otherwise a lot of other code (and
programmers) would go nuts..

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/