Re: [PATCH 27/35] core: move early_res

From: Yinghai Lu
Date: Tue Feb 16 2010 - 19:44:11 EST


On 02/16/2010 04:01 PM, H. Peter Anvin wrote:
> On 02/16/2010 03:53 PM, Yinghai Lu wrote:
>>>
>>> All this does would seem is it would change a build failure into a
>>> runtime panic. I really fail to see how this is an improvement...
>>
>> current only x86 support to early_res replace bootmem.
>>
>> later if other arch is using that feature, it need to provide that get_max_mapped.
>>
>
> If so, it would be better if this code isn't compiled at all on
> platforms that doesn't use it. Masking a compile-time failure with a
> runtime failure when the code isn't actually used doesn't seem like the
> right thing.

I would like to.

but for x86, with CONFIG_NO_BOOTMEM set or not, early_res are all used.

so we add CONFIG_HAVE_EARLY_RES ?

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/