Re: [PATCH 2/3] x86: set_personality_ia32() abuses TS_COMPAT

[H. Peter Anvin]

On 02/16/2010 09:16 AM, Oleg Nesterov wrote:
> 
> The only reason I dislike TS_COMPAT is that I spent a lot of time
> trying to understand the necessity to set it here when I tried to
> understand the basics of compat issues.
> 

Just to throw something else into here...

please also keep in mind that there is value to the notion of keeping a
software invariant true.  In this case, even if setting TS_COMPAT
doesn't do anything *right now*, it helps maintain an invariant which
might avoid bugs in the future.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/