Re: [tip:sched/urgent] sched: Fix sched_mv_power_savings for !SMT

[Vaidyanathan Srinivasan]

* tip-bot for Vaidyanathan Srinivasan <svaidy@xxxxxxxxxxxxxxxxxx> [2010-02-16 14:15:43]:

> Commit-ID:  28f5318167adf23b16c844b9c2253f355cb21796
> Gitweb:     http://git.kernel.org/tip/28f5318167adf23b16c844b9c2253f355cb21796
> Author:     Vaidyanathan Srinivasan <svaidy@xxxxxxxxxxxxxxxxxx>
> AuthorDate: Mon, 8 Feb 2010 15:35:55 +0530
> Committer:  Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> CommitDate: Tue, 16 Feb 2010 15:13:59 +0100
> 
> sched: Fix sched_mv_power_savings for !SMT
                ^^^^^ _mc_

Minor typo, the summary should be 
"sched: Fix sched_mc_power_savings for !SMT cases"

Thanks,
Vaidy

> Fix for sched_mc_powersavigs for pre-Nehalem platforms.
> Child sched domain should clear SD_PREFER_SIBLING if parent will have
> SD_POWERSAVINGS_BALANCE because they are contradicting.
> 
> Sets the flags correctly based on sched_mc_power_savings.
> 
> Signed-off-by: Vaidyanathan Srinivasan <svaidy@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> LKML-Reference: <20100208100555.GD2931@xxxxxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxx [2.6.32.x]
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> ---
>  include/linux/sched.h |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/sched.h b/include/linux/sched.h
> index 78efe7c..1f5fa53 100644
> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -878,7 +878,10 @@ static inline int sd_balance_for_mc_power(void)
>  	if (sched_smt_power_savings)
>  		return SD_POWERSAVINGS_BALANCE;
> 
> -	return SD_PREFER_SIBLING;
> +	if (!sched_mc_power_savings)
> +		return SD_PREFER_SIBLING;
> +
> +	return 0;
>  }
> 
>  static inline int sd_balance_for_package_power(void)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/