Re: [PATCH 2/2][RFC] tracing: Add extract out softirq names usedby irq trace events

From: Peter Zijlstra
Date: Sat Feb 13 2010 - 05:39:05 EST


On Fri, 2010-02-12 at 14:09 -0500, Steven Rostedt wrote:
> plain text document attachment (irq-events.patch)
> The irq trace events that map the softirq vectors to strings
> shows up in the format files as names. To allow binary parsers to
> be able to convert these names to their actual numbers, this patch
> extracts those enums.
>
> Signed-off-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
>
> ---
> include/trace/events/irq.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> Index: linux-trace.git/include/trace/events/irq.h
> ===================================================================
> --- linux-trace.git.orig/include/trace/events/irq.h 2010-02-12 13:29:44.000000000 -0500
> +++ linux-trace.git/include/trace/events/irq.h 2010-02-12 13:33:20.000000000 -0500
> @@ -7,6 +7,17 @@
> #include <linux/tracepoint.h>
> #include <linux/interrupt.h>
>
> +EXTRACT_TRACE_SYMBOL(HI_SOFTIRQ);
> +EXTRACT_TRACE_SYMBOL(TIMER_SOFTIRQ);
> +EXTRACT_TRACE_SYMBOL(NET_TX_SOFTIRQ);
> +EXTRACT_TRACE_SYMBOL(NET_RX_SOFTIRQ);
> +EXTRACT_TRACE_SYMBOL(BLOCK_SOFTIRQ);
> +EXTRACT_TRACE_SYMBOL(BLOCK_IOPOLL_SOFTIRQ);
> +EXTRACT_TRACE_SYMBOL(TASKLET_SOFTIRQ);
> +EXTRACT_TRACE_SYMBOL(SCHED_SOFTIRQ);
> +EXTRACT_TRACE_SYMBOL(HRTIMER_SOFTIRQ);
> +EXTRACT_TRACE_SYMBOL(RCU_SOFTIRQ);
> +

Still sucks you have to explicitly iterate them all, and far away from
the actual definition site too, its just asking to get out of whack with
reality.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/