Re: [patch v3 1/2] x86, ptrace: regset extensions to support xstate
From: Oleg Nesterov
Date: Fri Feb 12 2010 - 12:33:37 EST
On 02/11, Suresh Siddha wrote:
>
> --- tip.orig/arch/x86/include/asm/user.h
> +++ tip/arch/x86/include/asm/user.h
> ...
> +struct user_xstateregs {
> + struct {
> + __u64 fpx_space[58];
> + __u64 xstate_fx_sw[USER_XSTATE_FX_SW_WORDS];
> + } i387;
Perhaps a small comment can explain that user_xstateregs.i387 is
"equal" to struct i387_fxsave_struct. Otherwise it is not immediately
clear what xstateregs_get() actually copies into *ubuf
I don't think my ACK should be counted here, but the patch looks
good to me.
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/