Re: [PATCH 10/11] tracing/perf: Fix lock events recursions in thefast path

From: Peter Zijlstra
Date: Sun Feb 07 2010 - 04:46:46 EST


On Sat, 2010-02-06 at 17:10 +0100, Frederic Weisbecker wrote:
>
> > > Looks pretty what I'm looking for. Except that it still continues
> > > to fill and keep track of the locks held by the current thread,
> > > namely the copies in curr->held_locks.
> >
> > Which is exactly what you need for that lock hierarchy recording you
> > wanted :-)
>
>
> Well, the lock hierarchy should probably be retrieved from the traces,
> using state machines.
> Otherwise we would need yet other lock events for that, which is going
> to add even more overhead.


Right, well you could look at adding a mode that also strips out the
held_lock tracing, but since you really need the register class stuff to
re-generate the class mapping, avoiding the held_lock tracing doesn't
look like it's going to save you much, its all thread local storage.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/