Re: [PATCH] x86: keep chip_data in create_irq_nr

[H. Peter Anvin]

On 02/05/2010 01:05 PM, Brandon Philips wrote:
>>  
>> Index: linux-2.6/include/linux/irq.h
>> ===================================================================
>> --- linux-2.6.orig/include/linux/irq.h
>> +++ linux-2.6/include/linux/irq.h
>> @@ -400,6 +400,7 @@ static inline int irq_has_action(unsigne
>>  
>>  /* Dynamic irq helper functions */
>>  extern void dynamic_irq_init(unsigned int irq);
>> +void dynamic_irq_init_keep_chip_data(unsigned int irq);
>>  extern void dynamic_irq_cleanup(unsigned int irq);
> 
> Missing extern?
> 

Quite the opposite -- function prototypes don't need "extern", and
putting "extern" on them is generally considered bad style.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/