Re: linux-next: build failure after merge of the v4l-dvb tree

From: Mauro Carvalho Chehab
Date: Fri Feb 05 2010 - 10:02:51 EST


Stephen Rothwell wrote:
> Hi Mauro,
>
> After merging the scsi-post-merge tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/media/dvb/ngene/ngene-core.c: In function 'ngene_release_buffers':
> drivers/media/dvb/ngene/ngene-core.c:1443: error: implicit declaration of function 'vfree'
> drivers/media/dvb/ngene/ngene-core.c: In function 'ngene_get_buffers':
> drivers/media/dvb/ngene/ngene-core.c:1454: error: implicit declaration of function 'vmalloc'
> drivers/media/dvb/ngene/ngene-core.c:1454: warning: assignment makes pointer from integer without a cast
> drivers/media/dvb/ngene/ngene-core.c:1461: warning: assignment makes pointer from integer without a cast
> drivers/media/dvb/ngene/ngene-core.c:1467: warning: assignment makes pointer from integer without a cast
> drivers/media/dvb/ngene/ngene-core.c: In function 'ngene_probe':
> drivers/media/dvb/ngene/ngene-core.c:1836: warning: assignment makes pointer from integer without a cast
>
> Caused by commit b54c755d6263efe376f3dfc8c72c8e7b4fb4f4c1 ("V4L/DVB:
> ngene: Initial check-in").
>
> I added the following patch for today.
>
> From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Date: Fri, 5 Feb 2010 16:46:47 +1100
> Subject: [PATCH] V4L/DVB: using vmalloc requires include linux/vmalloc.h
>
> Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/dvb/ngene/ngene-core.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/dvb/ngene/ngene-core.c b/drivers/media/dvb/ngene/ngene-core.c
> index ea610e4..cb5982e 100644
> --- a/drivers/media/dvb/ngene/ngene-core.c
> +++ b/drivers/media/dvb/ngene/ngene-core.c
> @@ -41,6 +41,7 @@
> #include <linux/version.h>
> #include <linux/byteorder/generic.h>
> #include <linux/firmware.h>
> +#include <linux/vmalloc.h>
>
> #include "ngene.h"
>
Thanks for the patch. It looks sane to me. I'm adding it on my linux-next tree.

Cheers,
Mauro.

--

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/