Re: [PATCH v2 1/2] syslog: distinguish between /proc/kmsg andsyscalls

[James Morris]

On Thu, 4 Feb 2010, Kees Cook wrote:

> Hi Alex,
> 
> On Thu, Feb 04, 2010 at 08:58:43AM +0100, Alex Riesen wrote:
> > > +       /* /proc/kmsg can open be opened by CAP_SYS_ADMIN */
> > > +       if (type != 1 && from_file)
> > > +               return 0;
> > 
> > "can open be opened"?
> 
> Erk, sorry.  s/open //
> 
> James, do you want a patch for that?

I guess... and 'opened with' might be better.


-- 
James Morris
<jmorris@xxxxxxxxx>