Re: [PATCH 4/6] improve sys_personality for compat architectures

From: Arnd Bergmann
Date: Thu Feb 04 2010 - 02:41:39 EST


On Wednesday 03 February 2010, H. Peter Anvin wrote:
> The x86 method of simply not bothering doesn't seem to have caused
> problems -- our compat (and noncompat) tasks happily return PER_LINUX32
> if that is the mode and we don't seem to have had complaints with it.
> If userspace ever had an issue with it -- and they might have, at one
> point in history libc used to call personality() during startup, which
> it doesn't seem to anymore -- they presumably have worked through it.
>
> As such, I'm more than a little reluctant to change the current behavior.

I think it would be better to have a consistent behavior across
architectures, so /something/ should be changed. On x86, the unused
sys32_personality function can probable just be removed, if nothing
else.

If we can get everyone to agree with the x86 way of handling this,
we can also remove all the special cases for sys32_personality in the
other architectures.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/