Re: [PATCHv2 03/11] mxc: Fix Drive Strength Field in the IOMUXcontroller

[Amit Kucheria]

On 10 Feb 03, Grant Likely wrote:
> On Tue, Feb 2, 2010 at 10:16 PM, Amit Kucheria
> <amit.kucheria@xxxxxxxxxxxxx> wrote:
> > i.MX51 defines 4 values:
> >
> > 00: Low Drive Strength
> > 01: Medium Drive Strength
> > 10: High Drive Strength
> > 11: Max Drive Strength
> >
> > Signed-off-by: Amit Kucheria <amit.kucheria@xxxxxxxxxxxxx>
> > ---
> > Âarch/arm/plat-mxc/include/mach/iomux-v3.h | Â Â8 +++++---
> > Â1 files changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/plat-mxc/include/mach/iomux-v3.h b/arch/arm/plat-mxc/include/mach/iomux-v3.h
> > index 1deda01..f2f73d3 100644
> > --- a/arch/arm/plat-mxc/include/mach/iomux-v3.h
> > +++ b/arch/arm/plat-mxc/include/mach/iomux-v3.h
> > @@ -81,11 +81,13 @@ struct pad_desc {
> >
> > Â#define PAD_CTL_ODE Â Â Â Â Â Â Â Â Â Â(1 << 3)
> >
> > -#define PAD_CTL_DSE_STANDARD Â Â Â Â Â (0 << 1)
> > -#define PAD_CTL_DSE_HIGH Â Â Â Â Â Â Â (1 << 1)
> > -#define PAD_CTL_DSE_MAX Â Â Â Â Â Â Â Â Â Â Â Â(2 << 1)
> > +#define PAD_CTL_DSE_LOW Â Â Â Â Â Â Â Â Â Â Â Â(0 << 1)
> > +#define PAD_CTL_DSE_MED Â Â Â Â Â Â Â Â Â Â Â Â(1 << 1)
> > +#define PAD_CTL_DSE_HIGH Â Â Â Â Â Â Â (2 << 1)
> > +#define PAD_CTL_DSE_MAX Â Â Â Â Â Â Â Â Â Â Â Â(3 << 1)
> >
> > Â#define PAD_CTL_SRE_FAST Â Â Â Â Â Â Â (1 << 0)
> > +#define PAD_CTL_SRE_SLOW Â Â Â Â Â Â Â (0 << 0)
> 
> Shouldn't the addition/change of #defines be done in patches that
> actually use them?

I'll merge it into patch 5 that adds the core support for i.MX5. I kept it
separate because the #defines are a (standalone) property of the IOMUX
controller regardless of whether they are used by i.MX5 or not.

Thanks for all the reviews.

/Amit

-- 
-------------------------------------------------------------------------
Amit Kucheria,				 Kernel Developer, Verdurent
-------------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/