Re: [PATCH 5/14] blackfin: use generic ptrace_resume code

From: Mike Frysinger
Date: Wed Feb 03 2010 - 14:37:21 EST


On Tue, Feb 2, 2010 at 15:29, Mike Frysinger wrote:
> On Tue, Feb 2, 2010 at 13:59, Christoph Hellwig wrote:
>> Use the generic ptrace_resume code for PTRACE_SYSCALL, PTRACE_CONT,
>> PTRACE_KILL and PTRACE_SINGLESTEP. ÂThis implies defining
>> arch_has_single_step in <asm/ptrace.h> and implementing the
>> user_enable_single_step and user_disable_single_step functions, which
>> also causes the breakpoint information to be cleared on fork, which
>> could be considered a bug fix.
>>
>> Also the TIF_SYSCALL_TRACE thread flag is now cleared on PTRACE_KILL
>> which it previously wasn't which is consistent with all architectures
>> using the modern ptrace code.
>
> i have local code in the Blackfin tree that does part of this patch
> (and has been tested), so i'll split this patch apart and merge into
> my tree. Âthanks!

i added tracehook support to Blackfin recently, so that covered all
the new functions here. i just had to drop the handling of the
PTRACE_xxx things that common code already does.

when did you want to push through these updates ? i was planning on
sending these ptrace() updates through the Blackfin tree as part of my
2.6.34 queue. i'm guessing you didnt want this stuff in 2.6.33 ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/