Re: [PATCH 02/10] drivers/ata: Fix continuation line formats

[Jeff Garzik]

On 02/03/2010 12:21 PM, Mark Lord wrote:
> Joe Perches wrote:
> > String constants that are continued on subsequent lines with \
> > are not good.
> >
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> > ---
> > drivers/ata/pata_at91.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/ata/pata_at91.c b/drivers/ata/pata_at91.c
> > index 41c94b1..d222c0d 100644
> > --- a/drivers/ata/pata_at91.c
> > +++ b/drivers/ata/pata_at91.c
> > @@ -153,8 +153,8 @@ static void pata_at91_set_piomode(struct ata_port
> > *ap, struct ata_device *adev)
> > /* Compute ATA timing and set it to SMC */
> > ret = ata_timing_compute(adev, adev->pio_mode, &timing, 1000, 0);
> > if (ret) {
> > - dev_warn(ap->dev, "Failed to compute ATA timing %d, \
> > - set PIO_0 timing\n", ret);
> > + dev_warn(ap->dev, "Failed to compute ATA timing %d, set PIO_0
> > timing\n",
> > + ret);
> ..
>
> NAK. Just stick the ret); part onto the same line and be done with it.

Agreed...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/