Re: [PATCHv2 04/11] mxc: changes to common plat-mxc code to add support for i.MX5

From: Grant Likely
Date: Wed Feb 03 2010 - 11:41:14 EST


On Tue, Feb 2, 2010 at 10:16 PM, Amit Kucheria
<amit.kucheria@xxxxxxxxxxxxx> wrote:
> Changes separted to help in the review process

<soapbox>Commit log needs to talk about what the patch is, not how it
has changed. Please state what the patch does and why. It is also
helpful to have testing information. The goal is to make it easy for
both patch reviewers on the mailing list *and* people looking at the
commit in git after it is merged. This commit message doesn't provide
the reader with any helpful information.

Patch version/review information like your comment above typically
goes below the '---' line.</soapbox>

g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/