Re: [PATCH] dvb: return -ENOMEM if kzalloc failed in dvb_usb_device_init()

[Oliver Neukum]

Am Mittwoch, 3. Februar 2010 17:02:49 schrieb roel kluin:
> > The bug is caused by this:
> >
> >        if (cold) {
> >                info("found a '%s' in cold state, will try to load a firmware",desc->name);
> >                ret = dvb_usb_download_firmware(udev,props);
> >                if (!props->no_reconnect || ret != 0)
> >                        return ret;
> >        }
> >
> > which overwrites ret
> 
> Is that an ack or do you want me to add an int (e.g. rc) that
> handles the dvb_usb_download_firmware() return value?

This is an ack with an additional comment that this function is in need of
a cleanup due to unnecessary subtlety.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/