Re: [PATCH 2/2 v2] scsi: add scsi trace core function and put trace points

[Martin K. Petersen]

>>>>> "Kei" == Kei Tokunaga <tokunaga.keiich@xxxxxxxxxxxxxx> writes:

I'm traveling so I won't have time to look at this closely until next
week.  However, this caught my eye:

+static const char *
+scsi_trace_varlen(struct trace_seq *p, unsigned char *cdb, int len)
+{
+	switch (SERVICE_ACTION(cdb)) {
+	case READ_32:
+	case WRITE_32:
+		/* if protection is enabled */
+		if (((cdb[10] >> 5) & 0x7) == 1)
+			return scsi_trace_rw32(p, cdb, len);
+		/* fall through */
+	default:
+		return scsi_trace_misc(p, cdb, len);
+	}
+}

It is not a requirement that a 32-byte READ/WRITE request must have
PROTECT set.  So that if statement is bogus.

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/