Re: [PATCH] seastar - SeaStar Ethernet driver

From: Ben Hutchings
Date: Tue Feb 02 2010 - 17:12:52 EST


On Tue, 2010-02-02 at 13:59 -0800, Randy Dunlap wrote:
> On 02/02/10 12:58, Kevin Pedretti wrote:
[...]
> > +static void seastar_map_host_region(struct ss_priv *ssp, const void *addr)
> > +{
> > + /* Round addr to the nearest 128 MB */
> > + unsigned long raw_paddr = __pa(addr);
> > + unsigned long paddr = raw_paddr& ~((1<< 28) - 1);
> > +
> > + htb_map[8] = 0x8000 | ((paddr>> 28) + 0);
> > + htb_map[9] = 0x8000 | ((paddr>> 28) + 1);
>
> space before <<, &, and >>
[...]

The spacing looked correct here.

Ben.

--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/