Re: linux-next: sound tree build failure

From: Stephen Rothwell
Date: Tue Feb 02 2010 - 06:17:59 EST


Hi Mark,

On Tue, 2 Feb 2010 10:58:00 +0000 Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Feb 02, 2010 at 09:37:32PM +1100, Stephen Rothwell wrote:
>
> > The sound tree is merged before the mfd tree, and the commit that adds
> > those is only in the mfd tree. So the sound tree, on its own, is
> > broken. This driver will only build if you merge the mfd tree as well.
>
> Ah, you're doing builds after each individual merge. It might help to

Always have ...

> change the form you're using when reporting problems with partially
> constructed -next - at the minute you say "Today's linux-next build
> (x86_64 allmodconfig) failed like this:" which makes it look like you're
> testing the result of the full -next merge.

I was hoping that the subject of the email would help with that
impression.

> > Kconfig has nothing to do with it, sorry.
>
> No, it does really fix the problem. As I said the driver should build
> depend on a Kconfig symbol which is introduced in the MFD tree. This
> means that the driver will not be built at all until MFD has been merged
> since the dependencies required to select the driver will not be
> satisfied unless the commits it depends on are present in the tree.

Yeah, OK, I guess you could do that.

> I'll push a patch for this shortly.

Thanks.

--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature