Re: [PATCH 05/14] pci: add failed_list to record failed one for pci_bus_assign_resources

From: Yinghai Lu
Date: Fri Jan 15 2010 - 16:15:02 EST


On 01/15/2010 10:56 AM, Jesse Barnes wrote:
> On Tue, 22 Dec 2009 15:02:25 -0800
> Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>
>> so later we can do sth with those failed one
>>
>> -v2: store start, end, flags aside. so could keep res cleared when
>> assign failed. and make following assignment of its children do not
>> go wild
>>
>> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
>> ---
>> drivers/pci/setup-bus.c | 66
>> ++++++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 62
>> insertions(+), 4 deletions(-)
>
> Bjorn's comments still stand here, this patch doesn't make any sense by
> itself. Either the failed list functions and struct def should stand
> alone, or the whole thing should be rolled into the patch that actually
> makes use of these functions.
>

just want to make patch to be reviewed easyly.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/