Re: [RFC] [PATCH 3/7] Execution out of line (XOL)

From: Jim Keniston
Date: Fri Jan 15 2010 - 15:19:16 EST



On Fri, 2010-01-15 at 10:07 +0100, Peter Zijlstra wrote:
> On Thu, 2010-01-14 at 14:43 -0800, Jim Keniston wrote:
> >
> > Yeah, there's not a lot of context there. I hope it will make more
> > sense if you read section 1.1 of Documentation/uprobes.txt (patch #6).
> > Or look at get_insn_slot() in kprobes, and understand that we're trying
> > to do something similar in uprobes, where the instruction copies have to
> > reside in the user address space of the probed process.
>
> That's not the point, changelogs shoulnd not be this cryptic. They
> should be stand alone and descriptive of what, why and how.

Point taken.

>
> If you can't be bothered writing such for something you want reviewed
> for inclusion then I might not be bothered looking at them at all.
>

We appreciate your persistence wrt this patch set. :-}

Jim

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/