Re: [PATCH] typo in kernel source (DEBUGFS)

[Jiri Kosina]

On Fri, 15 Jan 2010, Jiri Kosina wrote:

> > 2010/1/13 Christoph Egger <siccegge@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>:
> > 
> > >        While working on this we detected a spelling error in
> > > drivers/mfd/ab3100-otp.c which can be corrected using the attached
> > > patch.
> > 
> > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>
> 
> The original patch misses a Signed-off-by. Please resend it to 
> trivial@xxxxxxxxxx with this line, so that it could be applied.

... and has this been tested at all?

drivers/mfd/ab3100-otp.c: In function ʽshow_otpʼ:
drivers/mfd/ab3100-otp.c:101: error: dereferencing pointer to incomplete type
drivers/mfd/ab3100-otp.c:104: error: implicit declaration of function ʽseq_printfʼ
drivers/mfd/ab3100-otp.c:102: warning: unused variable ʽerrʼ
drivers/mfd/ab3100-otp.c: In function ʽab3100_otp_openʼ:
drivers/mfd/ab3100-otp.c:116: error: implicit declaration of function ʽsingle_openʼ
drivers/mfd/ab3100-otp.c:116: error: ʽab3100_otp_showʼ undeclared (first use in this function)
drivers/mfd/ab3100-otp.c:116: error: (Each undeclared identifier is reported only once
drivers/mfd/ab3100-otp.c:116: error: for each function it appears in.)
drivers/mfd/ab3100-otp.c: At top level:
drivers/mfd/ab3100-otp.c:121: error: ʽseq_readʼ undeclared here (not in a function)
drivers/mfd/ab3100-otp.c:122: error: ʽseq_lseekʼ undeclared here (not in a function)
drivers/mfd/ab3100-otp.c:123: error: ʽsingle_releaseʼ undeclared here (not in a function)
drivers/mfd/ab3100-otp.c: In function ʽab3100_otp_init_debugfsʼ:
drivers/mfd/ab3100-otp.c:134: error: ʽerrʼ undeclared (first use in this function)
drivers/mfd/ab3100-otp.c: In function ʽab3100_otp_exit_debugfsʼ:
drivers/mfd/ab3100-otp.c:140: error: implicit declaration of function ʽdebugfs_remove_fileʼ

So looks like the debugfs code might need some more surgery.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/