Re: [PATCH] [NET]: da.s_net not copied but assigned to itself inaarp_rcv()

[Arnaldo Carvalho de Melo]

Em Thu, Jan 14, 2010 at 09:32:11PM +0100, Roel Kluin escreveu:
> da.s_net was not copied but assigned to itself.
> 
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>

Looks right, must be there for ages...

Acked-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

> ---
> diff --git a/net/appletalk/aarp.c b/net/appletalk/aarp.c
> index 9d4adfd..f2b3b56 100644
> --- a/net/appletalk/aarp.c
> +++ b/net/appletalk/aarp.c
> @@ -819,7 +819,7 @@ static int aarp_rcv(struct sk_buff *skb, struct net_device *dev,
>  				ma = &ifa->address;
>  			else { /* We need to make a copy of the entry. */
>  				da.s_node = sa.s_node;
> -				da.s_net = da.s_net;
> +				da.s_net = sa.s_net;
>  				ma = &da;
>  			}
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/