Re: [ RESEND PATCH v3] Memory-Hotplug: Fix the bug on interface/dev/mem for 64-bit kernel

From: Wu Fengguang
Date: Thu Jan 14 2010 - 09:08:41 EST


> > 2. pgdat->[start,end], totalram_pages etc...are updated at memory hotplug.
> > Please place the hook nearby them.
>
> arch/x86/mm/init_64.c:arch_add_memory() updates max_pfn_mapped, in
> this sense it's equally OK to update max_pfn/max_low_pfn etc before
> the call to arch_add_memory() ;)

Shaohui, I'd suggest to update max_pfn/max_low_pfn/high_memory in
arch/x86/mm/init_64.c:arch_add_memory() now, for X86_64.

Later on we can add code to arch/x86/mm/init_32.c:arch_add_memory()
for X86_32.

The code cannot be shared anyway.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/