Re: [lm-sensors] [patch] hwmon/amc6821: double unlock bug

[Jean Delvare]

On Thu, 14 Jan 2010 13:30:20 +0300, Dan Carpenter wrote:
> The mutex gets unlocked after we goto EXIT.
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> 
> --- orig/drivers/hwmon/amc6821.c	2010-01-14 13:22:23.000000000 +0300
> +++ devel/drivers/hwmon/amc6821.c	2010-01-14 13:22:30.000000000 +0300
> @@ -686,7 +686,6 @@ static ssize_t set_fan1_div(
>  		data->fan1_div = 4;
>  		break;
>  	default:
> -		mutex_unlock(&data->update_lock);
>  		count = -EINVAL;
>  		goto EXIT;
>  	}

Good catch. Applied, thanks.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/