Re: [PATCH] perf probe: Fix build failure

[Masami Hiramatsu]

Li Zefan wrote:
> Masami Hiramatsu wrote:
>> Hi,
>>
>> Thank you, the patch code looks good to me.
>>
>> Li Zefan wrote:
>>> builtin-probe.c:121: error: 'opt_show_lines' defined but not used
>>
>> Please add some comment for explanation, like:
>>
>> This build error occurs when compiling perf-tools without dwarf
>> support (no libdwarf).
>>
> 
> But as simple as this patch, the code itself has explained
> the cause of this compile error.

If someone looks git-log afterwords, below message seems too
short.
---
perf probe: Fix build failure

builtin-probe.c:121: error: 'opt_show_lines' defined but not used
---
Especially, if there is libdwarf, we will not see above error. So
IMHO, at least we'd better add a comment about how the error occurs.

Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@xxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/