Re: [PATCH] timers: Introduce the concept of timer slack for legacytimers

From: Andrew Morton
Date: Thu Jan 14 2010 - 01:08:55 EST


On Wed, 13 Jan 2010 21:45:28 -0800 Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> On Wed, 13 Jan 2010 13:52:19 -0800
> Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > I suppose this could be inlined.
>
> .. and then I expand it a bit in a few weeks and guess who complains an
> inline gets too big ? ;-)
>

Me!

You're proposing that we include trivially-fixed overhead to every
Linux machine in the world to save ourselves 15 minutes effort? Nope,
bad tradeoff.

> >
> > But the set_timer_slack() interface has no callers. Perhaps it
> > should?
>
> I have some callers pending, and I thought I posted those to lkml but
> maybe I did not.

hm.

Have you any feeling for how much power this sort of thing saves? I
guess "change in interrupts per minute" would be easy to measure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/