Re: [PATCH 2/3][v2] vmstat: add anon_scan_ratio field to zoneinfo

[KOSAKI Motohiro]

Hi

> Hi, Kosaki.
> 
> On Wed, Jan 13, 2010 at 5:21 PM, KOSAKI Motohiro
> <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:
> > Changelog
> > Âfrom v1
> > Â- get_anon_scan_ratio don't tak zone->lru_lock anymore
> > Â because zoneinfo_show_print takes zone->lock.
> 
> When I saw this changelog first, I got confused.
> That's because there is no relation between lru_lock and lock in zone.
> You mean zoneinfo is allowed to have a stale data?
> Tend to agree with it.

Well. zone->lock and zone->lru_lock should be not taked at the same time.
[1/4] of my last version removed zone->lock, then get_anon_scan_ratioo()
can take zone->lru_lock. but I dropped it. thus get_anon_scan_ration() can't
take zone->lru_lock.

Thus, I added need_update parameter.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/