Re: [PATCH -v2 5/5] x86: use dmi check to treat disabled cpus ashotplug cpus.

[H. Peter Anvin]

On 01/13/2010 02:23 PM, Andi Kleen wrote:
>> There are configurations in which percpu memory is in the megabytes.
> 
> There used to be some like this (with some broken debug code), but they
> got all fixed i believe to only allocate on real cpu hotplug. 
> 
> If not the right way is to fix them, not add DMI blacklists.
> 
> Beside when you enable debug code you probably don't care about 
> a few MB too much.
> 
>> This is exactly why we need high water mark allocation of percpu memory:
> 
> No we just need to fix any percpu pigs (if there are really any left,
> I did a couple of patches some time ago)
> 
> "Don't work around broken code -- fix it"
> 

Well, that *is* working around broken code, in this case the broken code
is the percpu allocation strategy.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/