Re: [PATCH] uwb: make USB device id constant

From: NÃmeth MÃrton
Date: Tue Jan 12 2010 - 11:58:11 EST


David Vrabel Ãrta:
> NÃmeth MÃrton wrote:
>> From: MÃrton NÃmeth <nm127@xxxxxxxxxxx>
>>
>> The id_table field of the struct usb_device_id is constant in <linux/usb.h>
>> so it is worth to make the initialization data also constant.
>
> Thanks.
>
>> The semantic match that finds this kind of pattern is as follows:
>> (http://coccinelle.lip6.fr/)
>
> Can you please not include this as part of the changelog in future? You
> may include it after the '---' if you wish.

It is common for patches generated by spatch that they include the SmPL
which was used to generate the patch.
See http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Ftorvalds%2Flinux-2.6.git&a=search&h=HEAD&st=commit&s=%3Csmpl%3E

But you can leave it out, if you wish.

Regards,

MÃrton NÃmeth
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/