Re: [PATCH 1/1] media: video/cx18, fix potential null dereference

[Jiri Slaby]

On 01/12/2010 12:48 AM, Andy Walls wrote:
> On Sun, 2010-01-10 at 09:56 +0100, Jiri Slaby wrote:
>> Stanse found a potential null dereference in cx18_dvb_start_feed
>> and cx18_dvb_stop_feed. There is a check for stream being NULL,
>> but it is dereferenced earlier. Move the dereference after the
>> check.
>>
>> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> 
> Reviewed-by: Andy Walls <awalls@xxxxxxxxx>
> Acked-by: Andy Walls <awalls@xxxxxxxxx>

You definitely know the code better, have you checked that it can happen
at all? I mean may demux->priv be NULL?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/