[PATCH] HTC Dream camera, not need sizeof

From: Pavel Vasilyev
Date: Mon Jan 11 2010 - 13:08:13 EST


http://bugzilla.kernel.org/show_bug.cgi?id=14825

Kernel version: git master (2.6.33-rc3-git3)


Description:

sizeof(extlen), always will be sizeof( unit32_t) or 4
It seems that something is wrong?!?!


-------

diff --git a/drivers/staging/dream/camera/msm_vfe7x.c
b/drivers/staging/dream/camera/msm_vfe7x.c
index 33ab3ac..4d39848 100644
--- a/drivers/staging/dream/camera/msm_vfe7x.c
+++ b/drivers/staging/dream/camera/msm_vfe7x.c
@@ -256,7 +256,7 @@ static int vfe_7x_init(struct msm_vfe_callback *presp,
extlen = sizeof(struct vfe_frame_extra);

extdata =
- kmalloc(sizeof(extlen), GFP_ATOMIC);
+ kmalloc(extlen, GFP_ATOMIC);
if (!extdata) {
rc = -ENOMEM;
goto init_fail;

----

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/