Re: [PATCH net-2.6 resent] af_packet: Don't use skb afterdev_queue_xmit()

[Jarek Poplawski]

On Sun, Jan 10, 2010 at 01:51:35PM -0800, David Miller wrote:
> From: Jarek Poplawski <jarkao2@xxxxxxxxx>
> Date: Sat, 9 Jan 2010 13:38:27 +0100
> 
> > tpacket_snd() can change and kfree an skb after dev_queue_xmit(),
> > which is illegal.
> > 
> > With debugging by: Stephen Hemminger <shemminger@xxxxxxxxxx>
> > 
> > Reported-by: Michael Breuer <mbreuer@xxxxxxxxxx>
> > Tested-by: Michael Breuer <mbreuer@xxxxxxxxxx>
> > Signed-off-by: Jarek Poplawski <jarkao2@xxxxxxxxx>
> > Acked-by: Stephen Hemminger <shemminger@xxxxxxxxxx>
> 
> Jarek, if this code path triggers, it will deadlock the
> send ring with your changes.
> 
> We will now leave the ring packet status in the "SENDING" state.
> 
> That's not right.

No, the destructor of this skb, tpacket_destruct_skb(), will clean
this. (Just like for other skbs kfreed during dev_queue_xmit().)

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/