Re: [PATCH 6/6] perf: Increase round-robin fairness of flexibleevents

[Paul Mackerras]

Frederic,

Nice to see someone working on the event scheduling in perf.

But I don't think this patch makes sense:

> Group of flexible events are round-robined in each tick so that
> each group has its chance to be scheduled. But the fairness
> per group granularity doesn't propagate inside the groups
> themselves.
> 
> If only the first events of each groups have a chance to make
> their way, the remaining ones will never be scheduled.
> 
> Hence this patch propagates the round-robin to the events
> inside the groups.

The semantic of a group is that either all of the events in the group
are scheduled in, or none of them are.  So it doesn't make sense to
talk about fairness within a group, and I don't see any point to
rotating the elements of the sibling_list.  Or have I misunderstood
what you're aiming at?

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/