Re: [PATCH] i2c: make PCI device id constant

From: Jean Delvare
Date: Sun Jan 10 2010 - 10:33:40 EST


Hi MÃrton,

On Sun, 10 Jan 2010 15:33:08 +0100, NÃmeth MÃrton wrote:
> From: MÃrton NÃmeth <nm127@xxxxxxxxxxx>
>
> The id_table field of the struct pci_driver is constant in <linux/pci.h>
> so it is worth to make initialization data also constant.
>
> The semantic match that finds this kind of pattern is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> disable decl_init,const_decl_init;
> identifier I1, I2, x;
> @@
> struct I1 {
> ...
> const struct I2 *x;
> ...
> };
> @s@
> identifier r.I1, y;
> identifier r.x, E;
> @@
> struct I1 y = {
> .x = E,
> };
> @c@
> identifier r.I2;
> identifier s.E;
> @@
> const struct I2 E[] = ... ;
> @depends on !c@
> identifier r.I2;
> identifier s.E;
> @@
> + const
> struct I2 E[] = ...;
> // </smpl>
>
> Signed-off-by: MÃrton NÃmeth <nm127@xxxxxxxxxxx>
> Cc: Julia Lawall <julia@xxxxxxx>
> Cc: cocci@xxxxxxx
> ---

Applied, thanks.

--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/