Re: [PATCH -mmotm-2010-01-06-14-34] check high watermark aftershrink zone

[Wu Fengguang]

On Fri, Jan 08, 2010 at 02:12:35PM +0900, Minchan Kim wrote:
> Kswapd check that zone have enough free by zone_water_mark.
> If any zone doesn't have enough page, it set all_zones_ok to zero.

> all_zone_ok makes kswapd retry not sleeping.

!all_zone_ok :)

> I think the watermark check before shrink zone is pointless.
> Kswapd try to shrink zone then the check is meaningul.
> 
> This patch move the check after shrink zone.

This tends to make kswapd do less work in one invocation, with lower
priority.  Looks at least not bad to me :) Thanks!

Reviewed-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/