Re: [RFC PATCH 0/2] Fix up the NFS mmap code

From: Linus Torvalds
Date: Fri Jan 08 2010 - 20:58:19 EST




On Sat, 9 Jan 2010, Al Viro wrote:
>
> readdir() is certainly a red herring.

That's the one that lockdep reports, though. I still don't see why. Afaik,
the only place where NFS gets an inode is nfs_fhget(), and that seems to
do things correctly.

> write(), OTOH, is quite real. And there we do i_mutex followed by
> pagefaults.

Ho humm..

> Could we please get a sane expalanation of the reasons why nfs mmap
> wants i_mutex in the first place? Before we add yet another hook
> from hell and complicate already overcomplicated area...

Yeah, agreed.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/