Re: [PATCH 1/3] generic sys_old_select

[H. Peter Anvin]

On 01/08/2010 01:31 AM, Christoph Hellwig wrote:
> On Wed, Jan 06, 2010 at 05:41:09PM +0000, Al Viro wrote:
>> Actually, I'd be a lot happier if we had lib/syscall/old_select.c, instead
>> of cluttering fs/select.c with that.  Objections?
> 
> If we do that let's do it consistantly for various old syscalls, not
> an odd one out.

Yes, and it would be a good idea to do so, rather than hiding all these
compatibility calls in all kind of random places.

There is, however, a reason *not* to do it which should be carefully
considered: by co-locating the compatibility version with the modern
version, it gets access to static functions that are part of the
implementation of the modern version.  If we move the compatibility
versions out, it may entail having to export those statics.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/