Re: users of mod_timer_msec()
From: Andi Kleen
Date: Sat Jan 02 2010 - 14:11:54 EST
Arjan van de Ven <arjan@xxxxxxxxxxxxx> writes:
> emp->activity++;
> if (!timer_pending(&emp->timer))
> - mod_timer(&emp->timer, jiffies + msecs_to_jiffies(10));
> + mod_timer_msec(&emp->timer, 10);
... but your original patch does
+int mod_timer_msec(struct timer_list *timer, unsigned long delay_ms)
+{
+ return mod_timer(timer, msecs_to_jiffies(delay_ms));
That doesn't look equivalent.
mod_timer_msec should mod_timer_msec_plus_jiffies?
-Andi
--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/