[PATCH] ACPI: Fix &&/|| confusion in acpi_evaluate_string() (in comment)

From: Roel Kluin
Date: Thu Dec 31 2009 - 06:53:55 EST


This always evaluates to true.

Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
---
drivers/acpi/utils.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

It's between an #if 0 ... #endif.

diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
index 811fec1..3495b43 100644
--- a/drivers/acpi/utils.c
+++ b/drivers/acpi/utils.c
@@ -312,7 +312,7 @@ acpi_evaluate_string(acpi_handle handle,
element = (acpi_object *) buffer.pointer;

if ((element->type != ACPI_TYPE_STRING)
- || (element->type != ACPI_TYPE_BUFFER)
+ && (element->type != ACPI_TYPE_BUFFER)
|| !element->string.length) {
acpi_util_eval_error(handle, pathname, AE_BAD_DATA);
return AE_BAD_DATA;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/