Re: [PATCH] drivers/atm/lanai.c: use %pM to show MAC address

From: Joe Perches
Date: Wed Dec 30 2009 - 13:59:54 EST


On Wed, 2009-12-30 at 13:50 -0500, H Hartley Sweeten wrote:
> Use the %pM kernel extension to display the MAC address.
> diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c
> index cf97c34..7fe7c32 100644
> --- a/drivers/atm/lanai.c
> +++ b/drivers/atm/lanai.c
[]
> @@ -2483,14 +2481,8 @@ static int lanai_proc_read(struct atm_dev *atmdev, loff_t *pos, char *page)
> return sprintf(page, "revision: board=%d, pci_if=%d\n",
> lanai->board_rev, (int) lanai->pci->revision);
> if (left-- == 0)
> - return sprintf(page, "EEPROM ESI: "
> - "%02X:%02X:%02X:%02X:%02X:%02X\n",
> - lanai->eeprom[EEPROM_MAC + 0],
> - lanai->eeprom[EEPROM_MAC + 1],
> - lanai->eeprom[EEPROM_MAC + 2],
> - lanai->eeprom[EEPROM_MAC + 3],
> - lanai->eeprom[EEPROM_MAC + 4],
> - lanai->eeprom[EEPROM_MAC + 5]);
> + return sprintf(page, "EEPROM ESI: %pM\n",
> + &lanai->eeprom[EEPROM_MAC]);

This is a user-visible change from upper case to lower case.
Probably doesn't matter, but maybe...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/