Re: [PATCH 00/14] USB: serial: fix DMA buffers on stack andendianess bugs

From: Johan Hovold
Date: Wed Dec 30 2009 - 12:33:50 EST


On Wed, Dec 30, 2009 at 06:06:11PM +0200, Dan Carpenter wrote:
> On Mon, Dec 28, 2009 at 11:01:44PM +0100, Johan Hovold wrote:
> > Hi,
> >
> > These patches should address all remaining instances of DMA buffers on stack
> > (being passed to usb_control_msg) for the usb serial drivers. They also fix a
> > few endianess bugs I found along the way and do some minor clean up.
> >
>
> Wow. You have inspired me again to update smatch. It didn't catch any of
> those.
>
> Smatch found one other dma bug so I'll send a patch for it. (I would feel like
> a jerk leaving it for you to fix on top of all the other stuff you have
> done.)

Good catch. I only backtracked from direct calls to usb_control_msg. :)
Doing so by hand can be quite tedious so automatic testing for this is
greatly appreciated.

Thanks,
Johan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/