Re: [ibm-acpi-devel] 2.6.33-rc2: regression: gkrellm no longer showsall the temperatures on thinkpad x60

From: Didier Spaier
Date: Mon Dec 28 2009 - 14:54:23 EST


Pavel Machek wrote:
On Sun 2009-12-27 23:32:59, Didier Spaier wrote:
Pavel Machek wrote:
On Sun 2009-12-27 23:24:15, Didier Spaier wrote:
Pavel Machek wrote:
...I'll have to find out where gkrell got that info. It worked in
2.6.32.

Pavel
Only to make sure... What is the output of cat /proc/acpi/ibm/thermal?

I ask that question because I noticed battery temperature 0° displayed by conky after updating to 2.6.32.2.
Looking at my .conkyrc I saw I tried to display ${smapi_bat_temp 0}
but I had forgotten to re-install the tp_smapi module.

Uhuh, there's no /proc/acpi/ibm:

ls /proc/acpi/ibm ls: cannot access /proc/acpi/ibm: No
such file or directory

. I guess that's the problem :-(. Config is:

CONFIG_THINKPAD_ACPI=y
# CONFIG_THINKPAD_ACPI_DEBUGFACILITIES is not set
# CONFIG_THINKPAD_ACPI_DEBUG is not set
CONFIG_THINKPAD_ACPI_UNSAFE_LEDS=y
CONFIG_THINKPAD_ACPI_VIDEO=y
# CONFIG_THINKPAD_ACPI_HOTKEY_POLL is not set

...so I do not see "enable legacy interface" option.

bash-3.1$ grep THINKPAD_ACPI /boot/config-2.6.32.2strip
CONFIG_THINKPAD_ACPI=m
CONFIG_THINKPAD_ACPI_DEBUGFACILITIES=y
CONFIG_THINKPAD_ACPI_DEBUG=y
CONFIG_THINKPAD_ACPI_UNSAFE_LEDS=y
CONFIG_THINKPAD_ACPI_VIDEO=y
CONFIG_THINKPAD_ACPI_HOTKEY_POLL=y
bash-3.1$

I suggest you modularize THINKPAD_ACPI.

How would modular version help?

I can't tell you how exactly.

But I can tell that is *does* work as a module, at least with 2.6.32.2.

Plus, reading Documentation/laptops/thinkpad-acpi make obvious IMHO,
though not explicitly stated, that it is supposed to be built as a module.

For instance 'grep module thinkpad-acpi|wc -l' returns 17 here ;)

And how the 'modprobe' command (founded twice in the same file) is supposed
to work with a driver built in the kernel image?

But of course deciding to try that or not is up to you :-)

Best regards,

Didier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/